On Fri, 8 Jan 2010 15:27:27 +1000, Peter Hutterer <[email protected]> 
wrote:

> Eventually the callbacks should be updated to work with InternalEvents (only
> RECORD actually uses the callbacks). Currently, WriteEventsToClient deals
> with wire events and changing it to keep the InternalEvent constitutes an
> ABI break.

I'm not quite sure I see the connection between using xEvents for the
callback and having WriteEventsToClient handle InternalEvents; it seems
like the callback should take InternalEvents and do what it likes with
those, including converting them to xEvents if necessary. In particular,
it looks to me like merging this patch will cause a whole bunch of
unnecessary work when RECORD is initialized, even if no-one is listening
for RECORD events, no?

-- 
[email protected]

Attachment: pgpc55QZROy1t.pgp
Description: PGP signature

_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to