On Fri, 2010-01-08 at 08:37 -0800, Dan Nicholson wrote: > On Fri, Jan 8, 2010 at 8:32 AM, Julien Cristau <[email protected]> wrote: > > On Fri, Jan 8, 2010 at 08:26:14 -0800, Dan Nicholson wrote: > > > >> This seems to have dropped the -I$(top_srcdir)/src that was being > >> mangled in in configure. Is that still needed? > >> > > It seemed to build fine without it, so I left it out.
Just a reminder to run 'make distcheck' for that type of changes. It exercises the paths in a different way as the build dir isn't the same as the source dir. In some cases, the order of includes is important when a header file is in multiple locations. Thanks for fixing this. > Yeah, none of the headers in there seem like they're needed outside of > that directory. None of them get installed, either, so you wouldn't be > picking up your system copy if you were missing the -I. > > Reviewed-by: Dan Nicholson <[email protected]> > > -- > Dan > _______________________________________________ > xorg-devel mailing list > [email protected] > http://lists.x.org/mailman/listinfo/xorg-devel
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
