Ed Schouten wrote:
> Hi folks,
>
> We at FreeBSD very recently gained support for utmpx, while removing
> utmp entirely. Our utmpx interface is very compact and should be quite
> pleasant to use. There aren't a lot of extensions to POSIX, which is
> described here:
>
> http://www.opengroup.org/onlinepubs/9699919799/basedefs/utmpx.h.html
> http://www.opengroup.org/onlinepubs/9699919799/functions/endutxent.html
>
> It seens the sessreg app is a bit antique and really depends on utmp
> being there. I've attached a patch to make it build with FreeBSD HEAD
> again.
The utmpx support was written on Solaris, which while it dropped the utmp
& wtmp files years ago, left the headers & functions for backwards
compatibility, so we never had to support building without them.
The patch looks pretty good, and I've confirmed it still builds fine on
Solaris. I do see one small style nit - the #ifdef/#endif indentation
doesn't match here, which could be confusing:
+# ifdef HAVE_UTMPX_NAME
+ if (utmpx_file != NULL)
+#endif
Can you add a 'Signed-off-by' tag ("git commit --amend -s" should do that),
and then submit the patch as output from git format-patch? That will help
us preserve the authorship and your comments, and I'll push that.
--
-Alan Coopersmith- [email protected]
Sun Microsystems, Inc. - X Window System Engineering
_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel
