On Feb 2, 2010, at 19:49, Dan Nicholson wrote:
>> - X11_REQUIRES="${X11_REQUIRES} xau xcmiscproto bigreqsproto"
>> + X11_REQUIRES="${X11_REQUIRES} xau [xcmiscproto >= 1.2.0]
>> [bigreqsproto >= 1.1.0]"
>
> Do these actually change anything? autoconf is just going to remove
> the [] after processing through m4, and having >= within quotes in
> shell is fine. There's a lot of this excessive quoting/unquoting in
> the x configure.ac's, and all that's really needed is to make sure
> that the arguments to the autoconf m4 macros are quoted...
I did it more for stylistic reasons.
>> - PKG_CHECK_MODULES(BIGFONT, xf86bigfontproto,
>> + PKG_CHECK_MODULES(BIGFONT, [xf86bigfontproto >= 1.2.0],
>
> like this. Can you show the warning that was being printed?
I'm not sure what you mean... I thought it was fairly obvious from the commit
message.
$ echo "#include <X11/extensions/xf86bigfstr.h>" | gcc -E - -o /dev/null
In file included from <stdin>:1:
./xf86bigfstr.h:1:2: warning: #warning "xf86bigfstr.h is obsolete and may be
removed in the future."
./xf86bigfstr.h:2:2: warning: #warning "include
<X11/extensions/xf86bigfproto.h> for the protocol defines."
_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel
