I've been doing that as I do other updates, but hadn't finished doing them all
yet, so thanks for finishing.

Reviewed-by: Alan Coopersmith <[email protected]>

Gaetan Nadon wrote:
> Compiler warning flags should be explicitly set in the makefile
> rather than being merged with other packages compiler flags.
> 
> Signed-off-by: Gaetan Nadon <[email protected]>
> ---
>  Makefile.am  |    2 +-
>  configure.ac |    1 -
>  2 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 15ddc27..3550c40 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -21,7 +21,7 @@
>  
>  bin_PROGRAMS = xkbcomp
>  
> -AM_CFLAGS = $(XKBCOMP_CFLAGS) -DDFLT_XKB_CONFIG_ROOT='"$(XKBCONFIGROOT)"'
> +AM_CFLAGS = $(XKBCOMP_CFLAGS) -DDFLT_XKB_CONFIG_ROOT='"$(XKBCONFIGROOT)"' 
> $(CWARNFLAGS)
>  xkbcomp_LDADD = $(XKBCOMP_LIBS)
>  
>  xkbcomp_SOURCES = \
> diff --git a/configure.ac b/configure.ac
> index 51457fc..4c86fcd 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -42,7 +42,6 @@ AC_CHECK_FUNCS([strdup strcasecmp])
>  
>  # Checks for pkg-config packages
>  PKG_CHECK_MODULES(XKBCOMP, x11 xkbfile)
> -XKBCOMP_CFLAGS="$CWARNFLAGS $XKBCOMP_CFLAGS"
>  AC_SUBST(XKBCOMP_CFLAGS)
>  AC_SUBST(XKBCOMP_LIBS)
>  

-- 
        -Alan Coopersmith-           [email protected]
         Sun Microsystems, Inc. - X Window System Engineering

_______________________________________________
xorg-devel mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to