On Wed, Feb 17, 2010 at 8:24 AM, Julien Cristau <[email protected]> wrote: > On Wed, Feb 17, 2010 at 06:14:08 -0800, Dan Nicholson wrote: > >> A return of BadIDChoice from NewInputDeviceRequest means that the device >> was explicitly ignored by the user. Don't spam the log with an error for >> this case. For udev, an error message has been added for real problems. >> >> Signed-off-by: Dan Nicholson <[email protected]> > > Acked-by: Julien Cristau <[email protected]> > > Although for most errors we already get errors in the log from the > driver (like when trying to use evdev on /dev/input/mouse*; I'm thinking > of making evdev log an info message if it gets a non-event device > instead of an error).
True, but NewInputDeviceRequest could bomb before it ever gets to the driver. Like if there isn't any configuration specifying a driver or the driver isn't installed or an OOM or something. I could see the other side of the argument, though. We do often log already for significant errors like no driver specified. -- Dan _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
