On Thu, Feb 25, 2010 at 12:35:00 +0200, Oliver McFadden wrote: > On Thu, 2010-02-25 at 11:25 +0100, ext Julien Cristau wrote: > > On Thu, Feb 25, 2010 at 10:21:07 +0200, Oliver McFadden wrote: > > > > > Previously this was not implemented because it requires the X server has > > > the xf86PostButtonEventP() function which was not released at the time. > > > > > Can you either keep the code working with older X servers with an ifdef, > > or update configure.ac to require a new enough xorg-server.pc? > > Yeah, this is probably a good idea. I'll dig through the X server log > later today and check which version is required. > > Also, which is preferred; an #if check on XORG_VERSION_CURRENT or a > configure.ac check? > I'd say either use xorg-server >= $version in configure.ac's PKG_CHECK_MODULES call (if you want to require a new server), or add an AC_CHECK_DECL(xf86PostButtonEventP) and a #ifdef (if you want to keep the driver working with older server).
Cheers, Julien
signature.asc
Description: Digital signature
_______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
