On Fri, Mar 05, 2010 at 02:12:00PM +0200, Oliver McFadden wrote: > are available in the git repository at: > > git://gitorious.org/omcfadde/xserver.git analysis > > Oliver McFadden (5): > exa: exaFinishAccess: Overrun of static array "pExaScr->access" of size > 6 at position 6 with index variable "i" > fb: fbFinishScreenInit: leaked_storage: Variable "(visuals|depths)" > goes out of scope > parser: xf86readConfigFile: unreachable: This code cannot be reached: > "free(val.str);" > common: xf86Configure: alloc_strlen: Allocated memory does not have > space for the terminating NUL of the string > Xext: IdleTimeBlockHandler: unsigned_compare: Comparing unsigned less > than zero is never true. "timeout < 0UL" > > Xext/sync.c | 4 +--- > exa/exa.c | 4 ++-- > fb/fbscreen.c | 4 ++++ > hw/xfree86/common/xf86Configure.c | 2 +- > hw/xfree86/parser/read.c | 4 ++-- > 5 files changed, 10 insertions(+), 8 deletions(-)
fwiw, I find it a lot easier to review patches that land on the mailing list than a pull request where I have to go off, pull into my tree, review and then copy/paste segments from the patch to be able to add comments. it also makes it harder to track when something has changed, since a tree doesn't usually contain the "Patch v3" part of it. Cheers, Peter _______________________________________________ xorg-devel mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-devel
