Le lundi 15 mars 2010 à 14:52 -0400, Adam Jackson a écrit : > On Thu, 2010-03-11 at 12:59 +0100, Michael Thayer wrote: > > http://cgit.freedesktop.org/xorg/xserver/tree/hw/xfree86/common/xf86Mode.c?id=326429badfc76885e4652ddc72860810c0e8d102#n1300 > > > > until line 1313 is supposed to be freeing the old list at > > scrp->clockRanges, duplicating the user supplied list and storing it > > there. If that is right, then it looks to me though like it will not > > work unless scrp->clockRanges is initially NULL > [snip] > I think your analysis is right, that code's garbage. > > At least in the case of virtual drivers like vboxvideo, I think we > should reasonably allow you to just pass in NULL for clockRanges. But > it's trivial to set up just one range that's sufficient to cover > everything. Gross, but sufficient. Certainly, and it's never caused me any pain - I just wanted to point it out in case it caught someone else at some point. And sorry for not trying a fix or anything, but I don't actually build the X server very often, just our own drivers.
Regards, Michael -- Sun Microsystems GmbH Michael Thayer Werkstrasse 24 VirtualBox engineer 71384 Weinstadt, Germany mailto:[email protected] Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, 85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Thomas Schroeder _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
