On Wed, Mar 17, 2010 at 2:43 PM, Julien Cristau <[email protected]> wrote: > On Wed, Mar 17, 2010 at 15:11:08 -0500, Yaakov (Cygwin/X) wrote: > >> diff --git a/hw/Makefile.am b/hw/Makefile.am >> index 7409906..92b007a 100644 >> --- a/hw/Makefile.am >> +++ b/hw/Makefile.am >> @@ -38,4 +38,4 @@ SUBDIRS = \ >> DIST_SUBDIRS = dmx xfree86 vfb xnest xwin xquartz kdrive >> >> relink: >> - for i in $(SUBDIRS) ; do $(MAKE) -C $$i relink ; done >> + $(AM_V_at)for i in $(SUBDIRS) ; do $(MAKE) -C $$i relink ; done > > This was there before, but: > AFAICT, this rule will succeed even if one of the subdir relink targets > fails, because the shell will keep going to the next iteration of the > loop. > > set -e; for i in $(SUBDIRS); do ...; done > > seems to do the trick, and properly fails as soon as one of the subdir > commands fails.
While I'm sure "set -e" would probably be fine, the typical way to handle this is just to add a "|| exit 1" after the action. This is how automake does it, for instance. -- Dan _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
