Am 23.03.2010 07:10, schrieb Peter Hutterer:
> On Tue, Mar 16, 2010 at 04:59:47PM +0100, Simon Thum wrote:
>> Since the fix is unintrusive, I propose it as a tempoary solution. And I
>> pledge to fix things later that year :)
>>
> 
> Reviewed-by: Peter Hutterer <[email protected]>
> can I have your signed-off though please?
attached, thanks!

> 
> Cheers,
>   Peter
>> From c935b1d8e5a49f22354d96c9863c4b73e9b9acf7 Mon Sep 17 00:00:00 2001
>> From: Simon Thum <[email protected]>
>> Date: Tue, 16 Mar 2010 16:00:21 +0100
>> Subject: [PATCH] move feedback initialization up
>>
>> This allows the backend to propery initialize the feedback from options,
>> as it works with most other drivers. This is the hacky equivalent of
>> fixing the initialization of pointer acceleration, which would require
>> changes to most drivers.
>> ---
>>  src/evdev.c |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/evdev.c b/src/evdev.c
>> index 3051462..63927db 100644
>> --- a/src/evdev.c
>> +++ b/src/evdev.c
>> @@ -1299,6 +1299,9 @@ EvdevAddRelClass(DeviceIntPtr device)
>>                                         GetMotionHistorySize(), Relative))
>>          return !Success;
>>  
>> +    if (!InitPtrFeedbackClassDeviceStruct(device, EvdevPtrCtrlProc))
>> +        return !Success;
>> +
>>      for (axis = REL_X; axis <= REL_MAX; axis++)
>>      {
>>          int axnum = pEvdev->axis_map[axis];
>> @@ -1315,9 +1318,6 @@ EvdevAddRelClass(DeviceIntPtr device)
>>  
>>      xfree(atoms);
>>  
>> -    if (!InitPtrFeedbackClassDeviceStruct(device, EvdevPtrCtrlProc))
>> -        return !Success;
>> -
>>      pInfo->flags |= XI86_POINTER_CAPABLE;
>>  
>>      return Success;
>> -- 
>> 1.6.4.4
>>
> 

>From c97770856e5fc8cf2a4ed7699534b4e4c6fff48c Mon Sep 17 00:00:00 2001
From: Simon Thum <[email protected]>
Date: Tue, 16 Mar 2010 16:00:21 +0100
Subject: [PATCH] move feedback initialization up

This allows the backend to propery initialize the feedback from options,
as it works with most other drivers. This is the hacky equivalent of
fixing the initialization of pointer acceleration, which would require
changes to most drivers however.

Signed-off-by: Simon Thum <[email protected]>
---
 src/evdev.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/evdev.c b/src/evdev.c
index 3051462..63927db 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1299,6 +1299,9 @@ EvdevAddRelClass(DeviceIntPtr device)
                                        GetMotionHistorySize(), Relative))
         return !Success;
 
+    if (!InitPtrFeedbackClassDeviceStruct(device, EvdevPtrCtrlProc))
+        return !Success;
+
     for (axis = REL_X; axis <= REL_MAX; axis++)
     {
         int axnum = pEvdev->axis_map[axis];
@@ -1315,9 +1318,6 @@ EvdevAddRelClass(DeviceIntPtr device)
 
     xfree(atoms);
 
-    if (!InitPtrFeedbackClassDeviceStruct(device, EvdevPtrCtrlProc))
-        return !Success;
-
     pInfo->flags |= XI86_POINTER_CAPABLE;
 
     return Success;
-- 
1.6.4.4

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to