On Wed, 2010-03-24 at 08:53 +0100, Rémi Cardona wrote: > Le 24/03/2010 07:21, Yaakov (Cygwin/X) a écrit : > > From: Yaakov Selkowitz <[email protected]> > > > > We now use libtool, which calls AC_PROG_SED and sets SED as the path to > > a fully-functional 'sed' (which may also be called 'gsed' if GNU sed is > > installed alongside a proprietary version). Therefore we should respect > > this value of SED so we are sure to use the correct one. > > Then configure should still call AC_PROG_SED explicitely. Relying on > libtool's macros for that _will_ bite us at some point. > > The rest of the patch is fine. >
I agree AC_PROG_SED and similar macros should be explicitly called. This alerts the reader that the program in question is used, so it also has a documentation benefit. It's of a great help to find where env variables are defined. > Cheers, > > Rémi > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
