Mikhail Gusarov wrote:
> Twas brillig at 08:31:41 13.04.2010 UTC-07 when [email protected]
> did gyre and gimble:
> AC> A couple formatting issues I note:
>
> AC> git am warned of a trailing whitespace issue when applying:
> AC> .dotest/patch:106: trailing whitespace.
> AC> snprintf(newwindowpath, len, "%s:%s",
>
> There's still lot of trailing whitespace in file. I tried to avoid
> touching it.
Yes, but git picked this one up because you edited that line anyway.
> Is it okay to rework it into patch series, starting with [PATCH 1/x]
> "reindent this stuff"?
Yes - if you apply a new consistent formatting style, doing that as the
first patch of a series seems fine to me. There used to be a recommended
set of flags to the indent program somewhere in the xserver docs, but I
think we may have dropped that file at some point.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
