On Fri, Apr 30, 2010 at 4:13 PM, Keith Packard <[email protected]> wrote: > + if (AllocARGBCursor(psrcbits, pmaskbits, > + NULL, &cm, > + 0, 0, 0, > + 0, 0, 0, > + &pCursor, serverClient, (XID)0) != Success) > + return NullCursor; > + > + if (!AddResource(FakeClientID(0), RT_CURSOR, (pointer) pCursor)) > + return NullCursor;
To what extent do people care if error paths like this leak memory? Should the AddResource failure free pCursor? I'm sure it hardly matters in *this* case but I wondered if this is something we should pay attention to on patch review. Jamey _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
