On Fri, 2010-05-14 at 07:19 +0200, ext Keith Packard wrote: > On Fri, 14 May 2010 07:58:40 +0300, Oliver McFadden > <[email protected]> wrote: > > > Please note this patch breaks the ABI. > > > > Signed-off-by: Oliver McFadden <[email protected]> > > --- > > hw/dmx/doc/dmx.sgml | 3 +-- > > hw/xquartz/quartz.c | 1 - > > include/scrnintstr.h | 10 ---------- > > mi/miexpose.c | 2 -- > > 4 files changed, 1 insertions(+), 15 deletions(-) > > ... > > diff --git a/mi/miexpose.c b/mi/miexpose.c > > index a99e530..bf4cfe5 100644 > > --- a/mi/miexpose.c > > +++ b/mi/miexpose.c > > @@ -297,7 +297,6 @@ miHandleExposures(DrawablePtr pSrcDrawable, DrawablePtr > > pDstDrawable, > > > > if (extents) > > { > > - /* PaintWindowBackground doesn't clip, so we have to */ > > REGION_INTERSECT(pscr, &rgnExposed, &rgnExposed, &pWin->clipList); > > } > > miPaintWindow((WindowPtr)pDstDrawable, &rgnExposed, PW_BACKGROUND); > > @@ -497,7 +496,6 @@ miWindowExposures( WindowPtr pWin, RegionPtr prgn, > > RegionPtr other_exposed) > > REGION_RESET( pWin->drawable.pScreen, exposures, &box); > > REGION_UNION( pWin->drawable.pScreen, prgn, prgn, exposures); > > } > > - /* PaintWindowBackground doesn't clip, so we have to */ > > I'd leave these comments in, just change them to miPaintWindow instead. > > Other than that, for both patches, > > Reviewed-by: Keith Packard <[email protected]>
Thanks. I'll send you a pull request in a bit. _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
