On Fri, May 7, 2010 at 11:19 PM, Keith Packard <[email protected]> wrote:
> diff --git a/hw/dmx/dmxgc.c b/hw/dmx/dmxgc.c
> index eb21d3c..40f312f 100644
> --- a/hw/dmx/dmxgc.c
> +++ b/hw/dmx/dmxgc.c
> @@ -382,6 +382,7 @@ void dmxChangeClip(GCPtr pGC, int type, pointer pvalue,
> int nrects)
> }
> break;
>
> +#if 0
> case CT_PIXMAP:
> case CT_UNSORTED:
> case CT_YSORTED:
> @@ -390,6 +391,7 @@ void dmxChangeClip(GCPtr pGC, int type, pointer pvalue,
> int nrects)
> /* These clip types are condensed down to either NONE or REGION
> in the mi code */
> break;
> +#endif
> }
>
> DMX_GC_FUNC_EPILOGUE(pGC);
The comment suggests that after unwrapping, pGC->funcs->ChangeClip is
miChangeClip. I just tried tracing through the layers of function
pointers and I *think* that's true. After miChangeClip returns,
clientClipType can only be either CT_REGION or CT_NONE. So this "fix"
should be correct. I'd rather see a "default: FatalError(...);" case
instead of commented-out code, though. Preserving or improving the
comment would be an added bonus.
I'd think the config/udev change should be replaced by Julien's patch,
which has been reviewed now.
For this remaining one-line change ;-) from your git tree:
hw/dmx/glxProxy/glxcmds.c:
- if (fbconfigId == NULL && visual == NULL) {
+ if (fbconfigId == None && visual == None) {
Reviewed-by: Jamey Sharp <[email protected]>
Jamey
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
