On Tue, 2010-05-18 at 17:14 -0700, Alan Coopersmith wrote: > Gaetan Nadon wrote: > > There are 2 problems which I think have a common cause: > > > > 'make clean' fails to remove xdmshell.1 which should not have been > > created in the first place. > > 'make distcheck' fails as it encounters xdmshell.1 > > > > I think the root cause is the .cpp suffix rule. However it cannot be > > removed as it used for other targets. > > It might be simpler to copy the design from one of the driver and put > > the man page in a /man subdir > > and renaming files to xdm*.man. It would be consistent with 90% of x.org > > modules. I just did one recently > > for libXft. > > Actually, the fix seems to be much simpler: > > --- a/Makefile.am > +++ b/Makefile.am > @@ -117,8 +117,8 @@ appman_DATA = $(appman_PRE:man.c...@app_man_suffix@) > noinst_DATA = $(noinst_man_PRE:man.c...@app_man_suffix@) > > MAINTAINERCLEANFILES = ChangeLog INSTALL > -CLEANFILES = $(appman_DATA) > -EXTRA_DIST = $(appman_PRE) > +CLEANFILES = $(appman_DATA) $(noinst_man_DATA) > +EXTRA_DIST = $(appman_PRE) $(noinst_man_PRE) > > include $(top_srcdir)/cpprules.in > > It may make sense to move the man pages to a subdir for consistency later, > but that didn't fix the issue when I tried it. >
Just moving into a subdir won't fix anything. I was referring to replacing the cpp method with the sed method used in 155 modules. If there is a quick fix in the mean time, perfect.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
