On Fri, 21 May 2010 17:44:54 -0700, Jamey Sharp <ja...@minilop.net> wrote:
> I have one thing I'm still confused about before I give my reviewed-by > for the series. "Change region implementation from macros to inline > functions" has an assortment of renamings in region.c to remove the > "mi" prefix from various names. Most of those are visible in > regionstr.h. Did you intend to defer those that late or did you want > to get them moved back to "Move region implementation from mi to dix", > where those changes were in the first place? Yeah, I should move those to the earlier mechanical patch, as you might imagine, these changes were done within emacs to clean up the un-exported symbols. I'll just add all of these symbols to the giant sed script so they get cleaned up earlier. > I'm pretty sure that renaming miValidateTree to ValidateTree in a > region.c comment was just an accident, but I'm less convinced about > your intent for the rest. Yup, just an accident as I removed all of the 'mi' prefixes. I've fixed that by explicitly renaming all of the private symbols in miregion.c and regionstr.h in the 'fix-miregion-private' script and running that in the first renaming patch. I also made the names 'EmptyBox' et al. less ambiguous by adding 'Region' to their new names. -- keith.pack...@intel.com
pgpDY2cDyOoR8.pgp
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
