On Wed, May 26, 2010 at 2:40 PM, Jamey Sharp <ja...@minilop.net> wrote: > Hi Alex! Thanks for reviewing! > > I can't merge this commit without the one before it, "Delete unused > GLX visual matching code." That code calls both the __glX*alloc > functions and the X*alloc ones, and I don't want to review it to see > whether it was relying on __glXMalloc to return NULL when passed a > size of 0. I wasn't so concerned about doing that review for this > patch when I found that the reference implementation of GLX already > made this change, but the reference implementation's visuals code was > gone by then. > > Could you (or somebody else) maybe review the "Delete unused GLX > visual matching code" patch too? >
I'm not too familiar with the glx code, but since this has already been removed from the server, I guess it should be safe to get rid of here as well. Does glxproxy even work? Alex > Thanks, > Jamey > > On Tue, May 25, 2010 at 10:20 PM, Alex Deucher <alexdeuc...@gmail.com> wrote: >> On Tue, May 25, 2010 at 7:53 PM, Jamey Sharp <ja...@minilop.net> wrote: >>> Kristian made equivalent edits to the reference GLX implementation in >>> 2006, with commit 2d2d38d17cc2558f8a41166a4a1578bc4c663c37. >> >> Reviewed-by: Alex Deucher <alexdeuc...@gmail.com> > _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
