Hi Chris,

On Wed, May 26, 2010 at 09:44:51PM +0200, ext Chris Wilson wrote:
> The move of the PCI device id probing into a separate file neglected to
> return the number of found devices, and so the PCI devices were being
> overwritten by the default entries for vesa and fbdev.
> 
> Signed-off-by: Chris Wilson <[email protected]>

Reviewed-by: Tiago Vignatti <[email protected]>


We also can add a short description here. Something like:

/*
 * @return The numbers of found devices that match with the current system
 * drivers.
 */

Can you amend this, please?

> -void
> +int
>  xf86PciMatchDriver(char* matches[], int nmatches) {
>      int i;
>      struct pci_device * info = NULL;
> @@ -1326,4 +1326,6 @@ xf86PciMatchDriver(char* matches[], int nmatches) {
>      if ((info != NULL) && (i < nmatches)) {
>       i += videoPtrToDriverList(info, &(matches[i]), nmatches - i);
>      }
> +
> +    return i;
>  }


Thanks,

        Tiago
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to