Mikhail Gusarov <[email protected]> wrote: > This patch has been generated by the following Coccinelle semantic patch: > > @@ > expression E; > @@ > > -if(E) { free(E); } > +free(E); > > Signed-off-by: Mikhail Gusarov <[email protected]>
Reviewed-by: Fernando Carrijo <[email protected]> By the way, the hunk below sounds rather fishy, right? > @@ -109,14 +107,10 @@ RRCreateOutputProperty (Atom property) > static void > RRDestroyOutputProperty (RRPropertyPtr prop) > { > - if (prop->valid_values) > - free(prop->valid_values); > - if (prop->current.data) > - free(prop->current.data); > - if (prop->pending.data) > - free(prop->pending.data); > - if (prop->valid_values) > - free(prop->valid_values); > + free(prop->valid_values); > + free(prop->current.data); > + free(prop->pending.data); > + free(prop->valid_values); > free(prop); > } But yeah, it's matter for an unrelated patch. _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
