On Sat, 19 Jun 2010 13:05:22 +0300, Tiago Vignatti <[email protected]> wrote: > Although vendor and board naming are used to create the configure file, the > server doesn't actually use it when fetching such file and probing devices. > > Reported-by: Richard Barnette <[email protected]> > Signed-off-by: Tiago Vignatti <[email protected]> > --- > from v1: > - remove two more superfluous assignments (kudos Keith). > > Richard and James put the review stamp before, but I preferred to remove given > there was two bugs spotted by Keith. Anyway, your review again would be much > appreciated.
Ok, so you're no longer setting the dev_vendor and dev_board values in this path. Why do dev_vendor and dev_board continue to exist in this structure then? And how about the configDevice path in xf86Config.c? Why is that still setting this values? I commented out the vendor and board values in the GDevRec, and then the dev_vendor and dev_board values in XF86ConfDeviceRec and discovered that nothing in the server uses them, other than to write out to a config file. It seems like a better patch would remove all of this stuff, lest we end up with code depending on values which are not getting set in some paths. -- [email protected]
pgplPubyYRMVF.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
