On 28/06/2010 15:53, Colin Harrison wrote:
Hi,
Tiago Vignattiw wrote
all right, I do agree. So if WIN32 macro means Xming only then I'd give my
review for your patch:
No that covers all Microsoft Windows builds...but lets hear what the
Cygwin/X people say.
That is not correct. WIN32 is not defined under cygwin
(This is somewhat counter-intuitive since the Win32 API is available, but see
http://cygwin.com/faq/faq-nochunks.html#faq.programming.preprocessor for
reasoning why)
Their tinderbox build is busted (and Xming) without this. See also
http://lists.x.org/archives/xorg-devel/2010-June/010538.html
So my patch strays a little out of my comfort zone :)
So that patch as it stands is fine with me :-)
I can't just change it to check defined(__MINGW__) || defined(__CYGWIN__), as
that prevents xfs (and possibly other users of libXfont) from building on
cygwin. I'll look into this some more and try to propose a solution :-)
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
