Jesse Adkins wrote: > I've noticed a few things while poking around Xorg lately. Would patches to > fix the following things be of use (and where should I send them?)
Patches should be sent to xorg-devel with Signed-off-by/etc. as described on: http://www.x.org/wiki/Development/Documentation/SubmittingPatches > * Lots of X libraries still use Xmalloc and others, instead of the regular > stdlib functions (despite the defines in Xserver now referencing the stdlib > functions). Unlike the X server, we can't break client library ABI, so I don't think removing Xalloc/XFree in them is an option. (This problem goes away for clients that port to xcb, but we'll probably be stuck maintaining libX11 for at least two or three more decades.) > * I still see some xorgcvs and XFree86 cvs tags on various files in > different libraries. Yes, various people have been slowly cleaning them out as we touch libraries/apps that have them, but there's been no organized effort to methodically purge them. > * Changing constructs like '#if x' to '#ifdef x' or 'if !x' to '#ifndef x' Those have different meanings and semantics, so changing them is not necessarily the correct thing to do. Do you have specific examples? We should certainly add some of these to: http://www.x.org/wiki/Development/Janitor http://www.x.org/wiki/ToDo (Even just performing the Janitorial task of combining both lists into one in the wiki would be a good start. 8-) ) -- -Alan Coopersmith- [email protected] Oracle Solaris Platform Engineering: X Window System _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
