On Mon, Jul 05, 2010 at 02:05:28PM +0300, Tiago Vignatti wrote: > Hi, > > On Sun, Jul 04, 2010 at 12:18:21PM +0200, ext Matthieu Herrb wrote: > > On Sun, Jul 04, 2010 at 11:45:46AM +0200, Jamey Sharp wrote: > > > IIRC, Tiago also posted some patch to clean up these macros, and I > > > think I liked that one better. I believe it turned them into inline > > > functions and killed the redundant GC variants. What happened to that > > > patch? > > > > > > > I don't know. It even has 2 reviewed-by: tags. > > > > I retire my patch if Tiago's one gets committed. But the current > > code in git doesn't build with gcc 2.95, just because the macros > > are poorly defined. > > it's living here: > > http://cgit.freedesktop.org/~vignatti/xserver/ [vgaarb-fixes] > git://anongit.freedesktop.org/~vignatti/xserver [vgaarb-fixes] > > > The reason that Keith didn't pull this branch is due the last patch there, > which he complained that could increase a bit the overhead for being a private > lookup. > > Matthieu, let me know if you need this for 1.9 so we can poke Keith, > eventually pulling the remaining patches. >
I would like to see at least the macro to inline functions part (patches 1-3 of your series) go in. But I can live without them. I've a bunch of other local changes anyways that I never manage to send upstreams because I fail to track HEAD and at the same time manage the stable versions for OpenBSD. -- Matthieu Herrb _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
