On Jul 9, 2010, at 3:20 PM, Pauli Nieminen wrote:
But actual patch has two problems. First, GetMSC is not NULL checked before calling it. This causes crash with driver that is using flipping without OML_sync_control. Second, same freeze would happen
I avoided a ds->GetMSC() NULL check because that code-path wouldn't be taken if OML_sync_control support in the DDX is missing. If you look at the top of DRI2SwapBuffers() there is a fallback path that is taken if those entry points are null.
for application that is using OML_sync_control if it was moved between areas where is different MSC. In my option actual patch should be reverted because it is not correct fix for the bug.
See my other response. thanks, -mario _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
