On Fri, 16 Jul 2010 15:29:01 -0400, Adam Jackson <[email protected]> wrote:
> Previous code assumed we were always 32bpp, so root window paint walked > off the end of the XImage and things went boom. <bikeshed?> My brain is small today; I looked at this patch and had to go read the code very carefully as it looks like it just adds an assignment to fb.bitsPerPixel, so it was hard to see where the above assuption occurred. I think it would be nicer if the patch removed the bogus assignments which are still there. </bikeshed?> -- [email protected]
pgp9r2bCUTjDG.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
