Hi Peter, Thanks for the comments.
On Thu, Aug 26, 2010 at 6:50 PM, Peter Hutterer <[email protected]> wrote: >> -if test x"${PREFIX}" = x ; then >> +if test x"${PREFIX}" = x -a -z "$LISTONLY" ; then > > nitpick: the rest of the script uses test foo && test foo instead of -a No problem. >> +if [ -z "$LISTONLY" ]; then >> + echo "Building to run $HOST_OS / $HOST_CPU ($HOST)" > > test or []? Would this be for consistency, or is there a difference between the two of which I'm not aware? In any case I'll switch it to 'test', no problem. > these few strike me as odd. you escape some of the env settings but not > others. might be better to define a setup_buildenv() that sets environment > variables and initialized the prefix and just skip the call to > setup_buildenv() if listonly is set. Okay, that's easy enough to do. Is there a way I can use git send-email such that what is sent will be a reply to this thread? Is there a way to add more to the email body when using git send-email if I want to add more comments above and beyond the commit message? Thanks for reviewing! :-) _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
