Macpaul Lin wrote:
> +#if 0
> +/*unsigned int IOPortBase; */ /* Memory mapped I/O port area */
> +unsigned int ioportBase; /* Memory mapped I/O port area */
> +asm(".weak ioportBase\n");
> +/*asm(".weak IOPortBase\n");*/
> +#endif
Why not just delete that section instead of putting more #if 0 mistakes
into our shared code base?
> +#if 1
> +static __inline__ void
> +outb(unsigned PORT_SIZE port, unsigned char val)
> +{
> + /**(volatile unsigned char*)(((unsigned PORT_SIZE)(port))+IOPortBase) =
> val;*/
> + *(volatile unsigned char*)(((unsigned PORT_SIZE)(port))) = val;
> + barrier();
> +}
[...]
> +#endif /*0*/
Don't know about your new CPU, but on the existing ones we support, 1 != 0.
More seriously, like the first comment, #if 0/1 are fine for debugging, but
putting them into commits going upstream just annoys the people who come
clean them out later.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
