On Mon, 2010-09-06 at 11:56 +1000, Peter Hutterer wrote: > This hook is only necessary for the keyboard driver to remove the race > condition between drain_console() and the driver's ReadInput (Bug 29969). > > The idea is that a driver that needs to handle events from the console > calls xf86ReplaceConsoleHandler() with it's own ReadInput (or NULL) and thus > removes the drain_console call. It's the driver's responsibility to restore > the previous behaviour when the driver is unloaded.
You may want to note that "(or NULL)" bit in the comment above xf86SetConsoleHandler, since otherwise you have to drill down to addInputHandler to figure it out. Likewise the if (old_handler) is redundant. Just cosmetics though. Reviewed-by: Adam Jackson <a...@redhat.com> - ajax
signature.asc
Description: This is a digitally signed message part
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
