On Fri, Sep 24, 2010 at 3:00 PM, Gaetan Nadon <[email protected]> wrote:
> On Fri, 2010-09-24 at 00:15 -0400, Trevor Woerner wrote:
> -    echo "Building $1 module component $2..."
> +    echo "Processing module/component \"$1/$2\""
>
> I like the above, but it is not related to the --cmd patch. One patch, one
> logical change.

I believe it is.

If you're performing a "git fetch" over all your repositories the
output doesn't make sense because the script will say:

"Building mesa module component mesa..."

But you're not building mesa/mesa, you're doing a "git fetch" on
mesa/mesa. As part of my testing I kept seeing the script say:
"Building X/Y" and felt it would be confusing to users to have a
script aways say it is building everything when in fact nothing is
being built.
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to