On Thu, 2010-09-30 at 17:26 -0400, Trevor Woerner wrote: > From: Trevor Woerner <[email protected]> > > Place into one location the logic to decide what to do with regards to > the following build modes: LISTONLY, RESUME, NOQUIT, and BUILD_ONE. > > Signed-off-by: Trevor Woerner <[email protected]> > --- > build.sh | 163 > ++++++++++++++++++++++++++++++++++++++++++++------------------ > 1 files changed, 116 insertions(+), 47 deletions(-) > > diff --git a/build.sh b/build.sh > index 3a57561..2bfcebb 100755 > --- a/build.sh > +++ b/build.sh > @@ -66,12 +66,8 @@ nonexistent_components="" > clonefailed_components="" > > failed() { > - if [ X"${NOQUIT}" != X ]; then > - echo "***** $1 failed on $2/$3" > - failed_components="$failed_components $2/$3" > - else > - exit 1 > - fi > + echo "***** $1 failed on $2/$3" > + failed_components="$failed_components $2/$3" > } > > # print a pretty title to separate the processing of each module > @@ -147,12 +143,18 @@ checkfortars() { > if [ X"$jj" = X"gz" ]; then > TAROPTS=xzf > fi > - tar $TAROPTS $TARFILE -C $ii || failed tar $1 $2 > + tar $TAROPTS $TARFILE -C $ii > + if [ $? -ne 0 ]; then > + failed tar $1 $2 > + return 1 > + fi >
I got distracted by this "return 1" change and there are quite a few of them. Could you split the patch to take this change out of way as it does not match the commit text. It would significantly reduce the size of the main patch. A random example where the code change is not related to (but of course, necessary) to the code mission of the patch. I know it's not always possible, I am not sure in this case, that's why I ask.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
