> From: Michel =?ISO-8859-1?Q?D=E4nzer?= <[email protected]> > Date: Fri, 01 Oct 2010 17:18:05 +0200 > > On Fre, 2010-10-01 at 08:07 -0400, Trevor Woerner wrote: > > From: Trevor Woerner <[email protected]> > > > > Signed-off-by: Trevor Woerner <[email protected]> > > --- > > src/drmmode_display.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/src/drmmode_display.c b/src/drmmode_display.c > > index a6038b2..57a8ec6 100644 > > --- a/src/drmmode_display.c > > +++ b/src/drmmode_display.c > > @@ -1145,7 +1145,6 @@ drmmode_xf86crtc_resize (ScrnInfoPtr scrn, int width, > > int height) > > width, height, -1, -1, pitch * cpp, > > info->fb_shadow); > > } > > - scrn->pixmapPrivate.ptr = ppix->devPrivate.ptr; > > Before applying this as is, someone should confirm that this line really > isn't needed with servers that have the pixmapPrivate field. It was > added in Jerome's commit 95385f0906f371a1ed6e60eb3e597e699c7a3222 ('kms: > Fix resizing when acceleration is disabled'), which indicates it might > be necessary when resizing the screen with acceleration disabled.
Also, drivers are supposed to work with some older servers as well, at least some of them. So even if removing that line for the current server is OK, it probably isn't for older servers. _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
