On 10/14/2010 09:08 PM, Aaron Plattner wrote:
On Thu, Oct 14, 2010 at 12:00:40PM -0700, Thomas Hellstrom wrote:
On 10/14/2010 06:11 PM, Thomas Hellstrom wrote:
Hi!

Isn't the commit

5c6a2f93ebc16a78093782b442306de23ae94e78
xfree86: Kill pixmapPrivate  with a vengeance (v2)

a major ABI breakage (It alters the layout of the ScreenInfoRec
structure and also there are drivers hacking the pixmatPrivate member to
workaround the problem of the root pixmap's data pointer being restored
on enableFBAccess).

Hmm. Judging from bug 30451 this breaks a number of drivers.
I suggest reverting this commit and, when the impact has been properly
investigated,
and the change is considered worth it, re-post a patch series with
patches to all affected "in-tree" drivers together with a major ABI bump.
This was discussed already: 
http://lists.x.org/archives/xorg-devel/2010-October/013684.html

The ABI version has already been bumped in master vs. server-1.9-branch: 
http://cgit.freedesktop.org/xorg/xserver/commit/?id=1a9022d

-- Aaron

Ah, Ok. Sorry for the fuzz.

/Thomas


_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to