On Thu, Oct 14, 2010 at 01:32:15PM -0400, Brett Ciphery wrote: > I'm wondering if someone can comment on the performance loss for the > below patch and whether it is significant enough to warrant a > full signature computation/hashing algorithm rewrite. > > The below was patched to libX11-1.1.3 to fix an issue with the > keysym-tables ks_tables.h in a cross compile environment. makekeys > generates this file according to signatures it computes from keysymdef.h > and it is used further in the building process. Though during runtime, > the signature is again computed for lookup into the keysym-table. > Problems can occur if there is a host-target mismatch (e.g. > 32bit<->64bit) as for some strings, e.g. Greek_upsilonaccentdieresis, the > signature which gets computed will overflow a 32bit register and the > mapping will not be the same as decided during compile. > > My proposed solution is below. I'm wondering about performance loss by > forcing an 'unsigned long long' onto a 32bit arch.
If you're looking for consistency across architectures, you'd be much better using uint32_t instead of unsigned long long. Cheers, Daniel
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
