On Fri, 2010-10-22 at 14:07 -0400, Trevor Woerner wrote:

> From: Trevor Woerner <[email protected]>
> 
> For those using 'gmake' instead of 'make'.
> 
> Signed-off-by: Trevor Woerner <[email protected]>
> 


Reviewed-by: Gaetan Nadon <[email protected]>

Suggestion for a follow-on patch.
There is an assumption that make, git and now gmake are present on the system.
This is not always the case. This is what I get when running 'gmake':

        util/modular/build.sh: 1152: gmake: not found
        [...]
        ***** gmake failed on util/macros
        error processing module/component:  "util/macros"


And this is what I get when running 'bogus':

        $ util/modular/build.sh -o util/macros --cmd bogus /home/nadon/xorg/src
        The script can only process 'make', 'gmake', or 'git' commands
        It can't process 'bogus' commands

Just thinking out loud here, maybe we should accept any command, so as
long as it exists.
Checking `which some_cmd` should be enough. This allows user to run any
script they want.
I haven't thought it through.

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to