On Sun, Oct 24, 2010 at 8:42 AM, walter harms <[email protected]> wrote: > Alan Coopersmith schrieb: >> While we're accommodating with one-off patches in weird formats, if you're >> going >> to be sending series, or plan on continuing to send patches, you need to >> start >> using git to create them, working of the current git masters, not out-of-date >> tarballs. >> > > I am no master of git-foo and i am happy that i could convince thunderbird > not to mangle the patches again. > The tar-ball is uses was the latest to get 1.0.8 and i used the tar-ball > because in internet connection is > not the best. Actualy i was testing a c-code checker; i found some problems > with the Xt code and did some patches.
It's not hard. For your patches the work flow would have been: git clone git://anongit.freedesktop.org/xorg/lib/libXt cd libXt vi blah # make your changes git commit -as # -a for all change, -s for add your Signed-off-by git format-patch HEAD^ # create a git formatted patch of your most recent commit git send-email [email protected] name-of-your.patch Try it, it's definitely not hard, but there is some learning involved. I also dare say that if your internet connection is bad, then git is going to be an improvement for you, especially in the case that you inevitably have to download another tarball containing an updated version of the code. >> Commit messages should not include "re, wh" in - these are recorded in the > > ok understand > >> commit history forever. Things like "libXt" should go inside the brackets >> around [PATCH] git strips off the [.*] header, and the rest of the subject >> line is the commit summary, and it's already obvious that all the entries >> in the libXt changelog came from libXt. > > so you expect [PATCH:ibXt 1.0.8] ? Well, patches should always be made against git (master branch, or maybe an older maintenance branch), so you shouldn't make patches against a 1.0.8 tarball anyway. But, assuming your patch was against git master, then it should be [PATCH libXt]. Thanks, and good work with the patches! :) Matt _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
