Le 27/10/2010 00:34, Peter Hutterer a écrit :
...
+    {
+        pInfo->flags = XI86_CONFIGURED;

You just undefined XI86_CONFIGURED... I'm a bit lost here.
The define seems to have been purged in ABI_XINPUT>= 12, so
shouldn't we #ifdef this or no?

The rest of the patch seems good.

right, this is a bit hard to detect from the patch context.
there are two EvdevPreInit, one for ABI<  12 and one for ABI 12, with the
former calling the latter as NewEvdevPreInit (see the context above).

This hunk is within a ABI<  12 ifdef, so XI86_CONFIGURED exists here.


ok, thanks,

Reviewed-by: Benjamin Tissoires <[email protected]>

Cheers,
Benjamin
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to