On Thu, 2010-11-11 at 08:42 +1000, Dave Airlie wrote:
> > +static int
> > +PanoramiXCompositeUnredirectSubwindows (ClientPtr client)
> > +{
> > + PanoramiXRes *win;
> > + int rc = 0, j;
> > + REQUEST(xCompositeUnredirectSubwindowsReq);
> > +
> > + REQUEST_SIZE_MATCH(xCompositeUnredirectSubwindowsReq);
> > +
> > + if ((rc = dixLookupResourceByType((void **)&win, stuff->window,
> > XRT_WINDOW,
> > + client, DixUnknownAccess))) {
> > + client->errorValue = stuff->window;
> > + return (rc == BadValue) ? BadWindow : rc;
> > + }
> > +
> > + FOR_NSCREENS_FORWARD(j) {
>
> are you missing the stuff->window magic in here?
Hah, indeed, nice catch.
> > + for (i = 1; i < PanoramiXNumScreens; i++)
> > + newPix->info[i].id = FakeClientID (client->index);
> > +
> > + FOR_NSCREENS(i) {
>
> Why do we FORWARD if FORWARD == default? (though probably a separate cleanup).
Yeah, lame, we should drop FOR_NSCREENS and always make the direction
explicit.
> With those addressed, feel free to add my reviewed by.
Thanks, will address and send the pull request.
- ajax
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
