On Thu, Nov 11, 2010 at 7:03 AM, Cyril Brulebois <[email protected]> wrote: > This patch has been prepared with the following Coccinelle semantic patch: > ... > +dixLookupResourceByType((pointer)&r, x, y, NullClient, DixUnknownAccess);
Like the other series, I'd prefer (pointer *) in these casts, and: > --- a/hw/dmx/glxProxy/glxcmds.c > +++ b/hw/dmx/glxProxy/glxcmds.c > @@ -1,6 +1,6 @@ > /* > - * SGI FREE SOFTWARE LICENSE B (Version 2.0, Sept. 18, 2008) > - * Copyright (C) 1991-2000 Silicon Graphics, Inc. All Rights Reserved. > + * SGI FREE SOFTWARE LICENSE B (Version 2.0, Sept. 18, 2008) Copyright > + * (C) 1991-2000 Silicon Graphics, Inc. All Rights Reserved. This word-wrapping looks accidental. With those trivial fixes, Reviewed-by: Jamey Sharp <[email protected]> Jamey _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
