Dan Nicholson <[email protected]> (14/11/2010):
> Why not just have it set skip since you already have the comment to
> use append() to add more packages? Then you don't have to worry
> about arch_skip being deleted.

Right, not sure why I didn't do that in the end. I guess I planned to
check it was possible to refine the variable afterwards, and forgot to
get rid of that extra variable dance afterwards. Addressed in v2.

> > --- /dev/null
> > +++ b/xorg.modules.skip
> 
> I think it would be a little nicer to call this "arch.skip" or
> something rather than moduleset + ".skip". This particular fix is
> generic to any xorg moduleset and would keep you from having to copy
> the file if you want to create a new custom moduleset.

ACK. That was the first name of the file, actually. But since one has
to specify a full path to that file (jhbuild can be called from
anywhere), I picked a suffix for an existing variable instead of
introducing a new one to avoid redundancies. v2 uses arch.skip again,
and sets a (“temporary”) variable in jhbuildrc to avoid duplicating
the modular path.

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to