On 11/12/2010 10:13 PM, Cyril Brulebois wrote: > Cyril Brulebois <[email protected]> (13/11/2010): >>> +extern WindowPtr XYToWindow(SpritePtr pSprite, int x, int y); >> ^^^^^^ ^^^^^^^^^^ >> Collateral damage? > > Apparently, that was intended, since it's used in a later commit > (“Input: Add initial multitouch support from Xi 2.1”), just not > documented in that commit, nor completely done. > >> Removing the quoted line fixes it. > > Instead, the fix would rather be removing the following lines from > dix/events.c in the same commit: > | -static WindowPtr XYToWindow( > | - SpritePtr pSprite, > | - int x, > | - int y > | -); > | - > > as well as removing the “static” keyword in front of the function > definition (in the same file).. > > so that XYToWindow() is no longer static, for real. That seems to > allow building with patches getting applied one by one (except for > the <stdint.h> include issue I mentioned in another mail).
Thanks for finding this conflation of commits. I've separated the XYToWindow non-static change to a separate commit, and I'll push the changes to my branch on fdo in a bit. -- Chase _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
