On 11/17/2010 01:25 AM, Peter Hutterer wrote: > On Fri, Nov 12, 2010 at 05:35:01PM -0500, Chase Douglas wrote: >> diff --git a/XI2.h b/XI2.h >> index 6ba1377..f3ee7f0 100644 >> --- a/XI2.h >> +++ b/XI2.h >> @@ -32,10 +32,12 @@ >> #define Dont_Check 0 >> #endif >> #define XInput_2_0 7 >> +#define XInput_2_1 8 > > coincidentally, that's a libXi-internal define that should be removed from > the protocol headers. I've got the patch ready for this, leave this one > as-is for now.
Ok. >> --- a/configure.ac >> +++ b/configure.ac >> @@ -1,5 +1,5 @@ >> AC_PREREQ([2.60]) >> -AC_INIT([InputProto], [2.0], >> [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg]) >> +AC_INIT([InputProto], [2.1], >> [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg]) > > bump to version 2.0.99.1 is better for now, we can't possibly claim this is > stable yet :) Good point! >> AM_INIT_AUTOMAKE([foreign dist-bzip2]) >> AM_MAINTAINER_MODE >> >> -- >> 1.7.1 > > I would _really_ like to see the XI2proto.txt patch for this too to see the > semantics of these changes. Ok, I applied the big diff of the XI2proto.txt from your multitouch tree and modified it where appropriate. I deleted all references to grabbing and did not add any new grab-like semantics at this time. > Reviewed-by: Peter Hutterer <[email protected]> > for this patch, but that's without knowing wider implications based on the > semantics. I've not added your tag since I added the XI2proto.txt changes. Please review again to be sure everything seems good. I'm going to assume that a Reviewed-by tag from you and Daniel is a mark of consensus agreement on the protocol changes laid out in the commit. I pushed the changes to my repo on fdo, and I'll send a new patch so we can do further inline review. Thanks, -- Chase _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
