Matt Turner wrote:
> From: Glenn Burkhardt <[email protected]>
> 
> Originally sent to xorg@ back in July 2007.
> http://lists.x.org/archives/xorg/2007-July/025997.html
> 
> ---
> Please don't ignore it this time.

It's Xaw, it's hard not to.

> -             if (width > constraint->width)
> +             if (width > constraint->width >> 1) /* avoid short int overflow 
> */

Parentheses please, for those without the C operator precedence rules memorized.

-- 
        -Alan Coopersmith-        [email protected]
         Oracle Solaris Platform Engineering: X Window System

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to