On Tue, Dec 7, 2010 at 08:10:37 -0800, Keith Packard wrote: > On Fri, 3 Dec 2010 18:16:47 +0100, Cyril Brulebois <[email protected]> wrote: > > Cyril Brulebois <[email protected]> (12/11/2010): > > > Turn glxproxy.a into glxproxy.la, and add an explicit dependency on dix. > > > > > > Signed-off-by: Cyril Brulebois <[email protected]> > > > > Could I please get a review for one of those patches? > > [PATCH 1/4] Fix GLX_LIBS vs. DMX_LIBS order. > > [PATCH 1/4] Fix dmx linking. > > Neither looks dangerous, but I don't know anything about the issues > they're trying to address. Anyone else have a clue about DMX? > IIRC the problem was that once (core) dmx got rid of the deprecated functions, the linker would discard dix/deprecated.o before seeing glxProxy/libglxproxy.a, which did need it.
I think I'd go for the first patch just because it's simpler. So add my Reviewed-by: Julien Cristau <[email protected]> for it. Cheers, Julien
signature.asc
Description: Digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
