On Thu, Dec 09, 2010 at 03:59:59PM +0000, Daniel Stone wrote: > On Wed, Dec 08, 2010 at 02:58:49PM +1000, Peter Hutterer wrote: > > Add a few checks for the existence of a valuator class on the device to > > avoid null-pointer dereferences for button events from devices without a > > valuator class. > > > > X.Org Bug 21457 <http://bugs.freedesktop.org/show_bug.cgi?id=21457> > > > > Signed-off-by: Peter Hutterer <[email protected]> > > I think you need to update clipAxis() as well, plus a couple more > branches in positionSprite (under the 'Crossed screen? Scale back to > device coordinates'), but with those done:
I'm not sure if we can cross the screen without having valuator movement, but this code doesn't always obey the time-space continuum, so who knows. I'll add the two checks, if anything they won't hurt, thanks. Cheers, Peter > Reviewed-by (for the series): Daniel Stone <[email protected]> _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
