On Fri, Dec 10, 2010 at 11:55 AM, Paulo Zanoni <[email protected]> wrote: > Ping? > > Any specific reason to reject it? > > (there's no maintainer in the xorg-docs/MAINTAINERS file) > > 2010/11/4 Paulo Zanoni <[email protected]>: >> fbdev seems to be the only video driver without MOD_CLASS_VIDEODRV >> >> Signed-off-by: Paulo Zanoni <[email protected]> >> --- >> src/fbdev.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/src/fbdev.c b/src/fbdev.c >> index c97ce1c..cb29bd2 100644 >> --- a/src/fbdev.c >> +++ b/src/fbdev.c >> @@ -151,7 +151,7 @@ static XF86ModuleVersionInfo FBDevVersRec = >> PACKAGE_VERSION_MAJOR, PACKAGE_VERSION_MINOR, >> PACKAGE_VERSION_PATCHLEVEL, >> ABI_CLASS_VIDEODRV, >> ABI_VIDEODRV_VERSION, >> - NULL, >> + MOD_CLASS_VIDEODRV, >> {0,0,0,0} >> }; >> >> -- >> 1.7.1 >> >> _______________________________________________ >> [email protected]: X.Org development >> Archives: http://lists.x.org/archives/xorg-devel >> Info: http://lists.x.org/mailman/listinfo/xorg-devel >> > > > > -- > Paulo Zanoni > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel >
I don't remember seeing this patch before. fbdev should be using this, because MOD_CLASS_NONE (aka NULL) is for stuff like xaa which doesn't do video things. Reviewed-by: Jesse Adkins <[email protected]> _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
