On Fri, 2010-12-17 at 08:35 -0500, Trevor Woerner wrote: > The following commit in lib/libXdmcp: > > commit b64cac63e0bcdd87bbfd19678552fd7ed1a3b58f > Author: Cristian RodrÃguez <[email protected]> > Date: Tue Dec 14 15:40:20 2010 -0500 > > Export only public API symbols > > Reviewed-by: Adam Jackson <[email protected]> > Signed-off-by: Cristian RodrÃguez <[email protected]> > > Causes xdm to fail to build because app/xdm/xdm/genauth.c can't find > the following symbols: > _XdmcpAuthSetup > _XdmcpAuthDoIt > _XdmcpWrapperToOddParity
I don't understand why this patch, and a few other similar ones, were pushed as they were Nacked by 4 reviewers. They should be reverted and redone properly. The problem that occurred is exactly what happens when relying on a naming convention. Sooner or later it will break. All other libraries do it in the source code. Gaetan > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
