On Wed, 2010-12-29 at 19:31 -0500, Trevor Woerner wrote: > On Wed, Dec 29, 2010 at 10:44 AM, Gaetan Nadon <[email protected]> wrote: > > +# Set the default value for BINDIR > > +if [ X"$BINDIR_SET" = X ]; then > > + BINDIR=$EPREFIX/bin > > +fi > > I wonder if the above snippet (and all other such snippets from this > patch set) could be moved into the setup_buildenv() function? I > believe the purpose of that function is to define/setup various > default values. Moving these snippets there too will keep all the > variable defining/setting all in one place?
Yes, much better. Thanks > > I'm guessing you already thought of this, though, because you have > added various checks to the setup_buildenv() function for these > variables. Nope, I had not thought about it. > > In the case where "build.sh -L" is called all this environment setup > isn't required, and is one of the reasons why all that code was moved > into that function.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
