On Fri, 31 Dec 2010 16:49:37 +0200, ville.syrj...@nokia.com wrote:
> From: Ville Syrjälä <ville.syrj...@nokia.com>
> 
> When SourceValidate is performed on a window with IncludeInferiors
> sub-window mode, force an immediate update of all the automatically
> redirected windows, so that the current window contents will be up
> to date.

Reviewed-by: Keith Packard <kei...@keithp.com>

> +    pScreen->SourceValidate = cs->SourceValidate;
> +    if (pDrawable->type == DRAWABLE_WINDOW && subWindowMode == 
> IncludeInferiors)
> +     compScreenUpdate (pScreen);
> +    if (pScreen->SourceValidate)
> +     (*pScreen->SourceValidate) (pDrawable, x, y, width, height,
> +                                 subWindowMode);
> +    cs->SourceValidate = pScreen->SourceValidate;
> +    pScreen->SourceValidate = compSourceValidate;

This looks a bit tricky -- unwrapping SourceValidate before calling
compScreenUpdate seems like the right order, but I wouldn't mind a nice
comment here as it's not the 'usual' order of operations for wrapping functions.

-- 
keith.pack...@intel.com

Attachment: pgpysYDRSfkoQ.pgp
Description: PGP signature

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to